Repository navigation
make selection machinery pluggable so that for instance we can use an… - #1537
Merged
Merged
Conversation
reiern70
force-pushed
the
reiern70/custom-selection
branch
from
August 28, 2026 15:01
fc9d26a to
9aa6fd1
Compare
solomax
reviewed
Aug 31, 2026
solomax
left a comment
solomax
left a comment
Contributor
There was a problem hiding this comment.
Do we need tests for this functionality? :)
| <link>https://nightlies.apache.org/wicket/apidocs/11.x</link> | ||
| <link>https://docs.spring.io/spring-framework/docs/6.0.x/javadoc-api</link> | ||
| <link>https://logback.qos.ch/apidocs</link> | ||
| <link>https://javadoc.io/doc/ch.qos.logback/logback-classic/1.5.18</link> |
Contributor
Author
I will see what I can do. I tested examples and they are still working. I can also add some exaple no how to use this feature. |
… ID based mechanism
… ID based mechanism
… ID based mechanism
reiern70
force-pushed
the
reiern70/custom-selection
branch
from
September 2, 2026 20:16
8dda8cb to
c100a70
Compare
Contributor
Author
It seems there are no tests regarding autocomplete. I just added some example Screencast.From.2026-09-02.15-58-45.webm |
Contributor
Author
|
@solomax I included your feedback + some examples. I would appreciate another review |
solomax
approved these changes
Sep 3, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… ID based mechanism